vmangos / core

Progressive Vanilla Core aimed at all versions from 1.2 to 1.12
GNU General Public License v2.0
663 stars 478 forks source link

πŸ› [Bug] Spell batching issue with proc spells #1723

Open jaywalker15262 opened 1 year ago

jaywalker15262 commented 1 year ago

πŸ› Bug report

Bloodthirst consumes a stack of its proc as it generates them. Meaning if u use BT, it will generate 3 stacks then consume a stack. That is because of batching that causes the spell to land after the proc has happened i assume. It was not like this before I believe, at the very least it is not how it worked in vanilla.

Expected behavior

So spells or abilities such as Bloodthirst that both cause a proc and consume its own procs, consume a stack of its proc as soon as it is casted when it should not. So for instance bloodthirst, as the description says, your NEXT 3 melee attacks causes u to heal X amount, so its not suppost to heal for X amount then have 2 procs left. Old vanilla videos show the same case. Right now it consumes its own stacks with the batching delays u have in the config. It is suppost to deal damage then leave u with a proc that had 3 stacks that heals on melee attacks. Only BT’s that happen after the proc can proc a stack, not before u even have proc on u.

Steps to reproduce

  1. Get 30 rage
  2. Wait until right after next swing to use BT so swing doesnt mess with stack count
  3. Watch stack count
  4. ...
  5. Profit

Version & Environment

Commit Hash:

OS Client: OS Server:

Crashlog

jaywalker15262 commented 1 year ago

Any update on this? Do u guys agree this is a bug? Anyone tried to replicate it? I wrote a workaround for it(hackfix) if a general fix cannot be applied

ratkosrb commented 1 year ago

Wall had reported a similar issue with Frostbite being broken by spell that applies it, but I couldn't reproduce it at the time. Have not tested this one yet.

jaywalker15262 commented 1 year ago

Wall had reported a similar issue with Frostbite being broken by spell that applies it, but I couldn't reproduce it at the time. Have not tested this one yet.

Have you tested it yet?

jaywalker15262 commented 1 year ago

Latest vmangos commits has not yet solved this. It did fix procs like Frostbite but things like Bloodthirst are still bugged by spellbatching.