search

vmangos / core

Progressive Vanilla Core aimed at all versions from 1.2 to 1.12
GNU General Public License v2.0
688 stars 491 forks source link

Ravager Axe🐛 [Bug] #1786

Open Hanzemon opened 1 year ago

Hanzemon commented 1 year ago

🐛 Bug report

Right now the item Ravager is super weak. It has 3 bugs.

  1. When the enemy you were targetting when the Channel starts dies, the channeling stops.
  2. It does not proc of itself.
  3. It does not proc any enchant on the weapon or trinket. [edit] 4. Crits from Ravager when Channeling Whirlwind don't trigger Deep Wounds.

Expected behavior

Here you can see ravager proccing Fiery weapon. https://www.youtube.com/watch?v=PbtqPFx3qoM Here you can see ravager proccing off itself and not being cancelled when targets die. https://www.youtube.com/watch?v=7BARDYrbFQM

Steps to reproduce

  1. A dev better skilled than me will know better how to reproduce the bugs described here.

Version & Environment

Client Version:

OS Client: OS Server:

Crashlog

Nescitum commented 1 year ago

While I'm not too experienced. https://github.com/vmangos/core/commit/3f91713bed5b8f91046ebfbc9a903cee6faa87ca this commit changes and removes SPELL_ATTR_EX2_TRIGGERED_CAN_TRIGGER_PROC which is the attributeex2 assigned to Ravagers bladestorm spell, which may be what is effecting issue 2 and 3.

scottnice commented 1 year ago

@Hanzemon @Nescitum I have a fix for it here just need to push to get it merged https://github.com/vmangos/core/pull/2162

scottnice commented 1 year ago

Video of Ravager proccing flame tongue https://www.youtube.com/watch?v=_Ela9MIoR_E You can also see in this video, ravager renewing its proc when its whirlwind lands.