vmangos / core

Progressive Vanilla Core aimed at all versions from 1.2 to 1.12
GNU General Public License v2.0
646 stars 529 forks source link

Sweeping strikes like on classic #2650

Open Otari98 opened 3 weeks ago

Otari98 commented 3 weeks ago

🍰 Pullrequest

Title ^

Proof

Issues and videos from classic in this discussion (https://github.com/vmangos/core/issues/2647)

How2Test

create warrior .level 59 .cheat power on .cheat cooldown on .npc summon 17685 x4 .learn 12292 .learn 1680 .learn 11574 .learn 20569

Todo / Checklist

-- Still not perfect. On classic fully dodged/parried whirlwind still procs SS. (doesnt make sense but thats how it is there) -- changing this line in UnitAuraProcHandler

if (!target) return SPELL_AURA_PROC_FAILED;

to SPELL_AURA_PROC_OK enables stacks to burn while solo target. It might allow to get accidentaly pvp flagged, although i dont think it was preventing that from happening before anyway.