🦂 [Bug]LBRS - Flame Buffet totem wrong spell ID

🦂 Bug report - Dungeon

The Flame Buffet Totem's(cast by Smolderthorn Witch Doctor) Flame Buffet spell has the wrong spell ID

Expected behavior

https://www.wowhead.com/classic/npc=9266/smolderthorn-witch-doctor their totem - > https://www.wowhead.com/classic/npc=10217/flame-buffet-totem wrong spell id https://www.wowhead.com/classic/spell=16168/flame-buffet - current one (deals 800 damage) https://www.wowhead.com/classic/spell=9574/flame-buffet - correct one https://youtu.be/qUeh_vws5YE?t=1125

I don't know how to commit sql fixes


UPDATE `mangos`.`creature_template` SET `spell_id1`=9574 WHERE  `entry`=10217 AND `patch`=0;
UPDATE `mangos`.`creature_template` SET `spell_id1`=9574 WHERE  `entry`=10217 AND `patch`=10;

Version & Environment

Client Version: 1.12.1

I don't know how to commit sql fixes

Open the sql directory in a terminal and run one of the following scripts (depending on your operating system/environment):

./touch_migration.sh
# or
python make_migration.py

If you are on Windows, you can instead also run the make_migration.bat script, afaik simply by double-clicking it in Windows Explorer (and I am sure you can run it from a cmd or PowerShell session too).

All of these scripts should produce a new, time-stamped file in sql/migrations, e.g., /sql/migrations/20240620215951_world.sql, which will look like this:

DROP PROCEDURE IF EXISTS add_migration;
DELIMITER ??
CREATE PROCEDURE `add_migration`()
BEGIN
DECLARE v INT DEFAULT 1;
SET v = (SELECT COUNT(*) FROM `migrations` WHERE `id`='20240620215951');
IF v = 0 THEN
INSERT INTO `migrations` VALUES ('20240620215951');
-- Add your query below.

-- End of migration.
END IF;
END??
DELIMITER ;
CALL add_migration();
DROP PROCEDURE IF EXISTS add_migration;

Now you'll simply have to add your SQL statements between the -- Add your query below. and the -- End of migration. comments and make a PR that includes this new file.

Note that the SQL syntax/style should match the existing migrations. E.g., in the fix you posted (without checking the fix itself) you would have to remove the database name (because it shouldn't be assumed that the database name will always be mangos), so instead of

UPDATE `mangos`.`creature_template` -- ...

you would just write

UPDATE `creature_template` -- ...

vmangos / core