WIP Fix patch for several objects/NPCs.

Daribon commented 1 week ago

🍰 Pullrequest

This PR fixes the patch for several objects/NPCs that should not be spawned in earlier versions of the game. The PR also adds two objects that were previously missing from alliance/horde camp, used only pre patch 1.12.

Proof

The horde and alliance camps were added in 1.9.0 and then in patch 1.12.0 the terrain changed when the sandlol pvp event was added.
Images from vanilla camps pre 1.12: March 27, 2006: Unknown date pre 1.12:

From vmangos after PR applied: WoW_NxjF8de0cA WoW_ExvXibchLA

Old images from from Cenarion Hold pre 1.9: Wearing old t2 art, t2 was updated in 1.9 so this image is from 1.8 (Hallows End was added in 1.8 October 10 2005): 58965626301 Wearing old t2 art, t2 was updated in 1.9 so this image is from 1.8 (Hallows End was added in 1.8 October 10 2005): 58965626300 Unknown date, but from originally from same image folder as the rogue wearing old t2. (Hallows End was added in 1.8 October 10 2005): 58965626302 Wearing old t2 art, t2 was updated in 1.9 so this image is from 1.8 (Hallows End was added in 1.8 October 10 2005): 58965626308 Wearing old t2 art, t2 was updated in 1.9 so this image is from 1.8 (Hallows End was added in 1.8 October 10 2005): 58965626309 Unknown date, but from originally from same image folder as the rogue wearing old t2. 58965626319 Unknown date, but as the Cenarion Hold Infantry are mounted, I believe its from 1.8: ThebattlefieldofCenarionHold

September 30, 2005 (patch 1.8.2): Unknown date, but as the Cenarion Hold Infantry are mounted, I believe its from 1.8: This image is dated July 22, 2006 (patch 1.11.2) Why the guard by the ladder is not spawned I do not know. It's possible it was added in later patch than 1.9.: It's possible in this image that someone has bugged the NPC into a pillar, since there is a very faint C in the middle of the screen inside the pillar.

Issues

None

How2Test

Use 1.7.1 or set wowpatch to 5
Try to .go creature or .go ob any of the guids

Todo / Checklist

[X] None

Daribon commented 1 week ago

Added two objects that were previously missing from both alliance and horde camp in Silithus, in pre patch 1.12.

Daribon commented 1 week ago

Updated with removal of several Cenarion Hold guards pre 1.9. I think I've missed some NPCs, since I don't have images in all angles of Cenarion Hold. Some more dated images would be nice since the guard by the ladder has me confused why it would not be spawned post 1.9.

Needs more research.

vmangos / core