vmangos / core

Progressive Vanilla Core aimed at all versions from 1.2 to 1.12
GNU General Public License v2.0
669 stars 481 forks source link

🐝 [Bug]The Only Prescription task cannot be obtained Chapter 7 Draconic for Dummies #2704

Closed yybss closed 1 week ago

yybss commented 2 months ago

When the player completes the Gates of Ahn'Qiraj mission: The Only Solution, Chapter 7 The Dragon Language Tutorial for Dummies will appear on the table in Blackwing Lair, but the player cannot obtain it correctly. The page appears blank after opening, but after I use the GM account to enable GM permissions, it becomes normal and other players cannot obtain it. 微信截图_20240720233124 微信图片_20240720233144

yybss commented 2 months ago

The core is 20240605

Daribon commented 2 months ago

It's possible that I might have broken it when I was respawning BWL. On first glance I cannot see anything that would break it, but I will have a deeper look soon: https://github.com/vmangos/core/commit/e454aeb9396cacad8ab393c115fa298fca8302a0#diff-75302771e9ef7bc9de0d73e8d7c76ce17cabb091e261263c5b08313fe1da66cfR429

Daribon commented 2 months ago

Can't reproduce on 1.12.1 enUS: WoW_j9aDok0DP2 It opens without any issue without gm on.

Can't reproduce on 1.12.1 zhCN: Wowsad_zdZwqjNCJj The gossip text appears to be wrong, but the gossip option does show up as expected.

Oddly the gossip text does show up in complete draconic for all other languages: deDE: WoW_zoYnNEM4Uw krKR: WoW_IjxZQyBKQa So maybe the gossip text is just a client bug where it cannot do more than a word in draconic when chinese locale.

As for the gossip option not showing up in non gm mode, it works for me on every locale so perhaps try clearning cache.

gajet5 commented 2 months ago

I also had a player with this problem on my server. I couldn't repeat it on another character.

FlagFlayer commented 1 week ago

I think the gossip_menu_options are using the wrong conditions:

gossip_menu_option 6669 uses condition 151 (Checks if you have The Only Perscription AND DO NOT have Chapter VII of Draconic for Dummies) and is tied to gossip_script 6669 which uses the spell 25764 which gives you Draconic for Dummies Chapter V (not VII).

Opposite is true for 6668 (gives Chapter VII, checks for not having Chapter V)

Should be a quick fix, I'll open a PR for it.