search

vmangos / core

Progressive Vanilla Core aimed at all versions from 1.2 to 1.12
GNU General Public License v2.0
665 stars 480 forks source link

🐞 [Bug] - Judgement of Light just triggered once #2708

Open Elmo337 opened 1 month ago

Elmo337 commented 1 month ago

🐞 Bug report - Spell

Seal of Righteousness (SoR) hits are supposed to count as weapon hits for proc effects, including things like Judgement of Light (JoL).

In my testing so far I've never seen JoL proc twice at once like it should through SoR.

image

Expected behavior

https://www.youtube.com/watch?v=XcJL5rz5QXs

https://www.youtube.com/watch?v=lrwWFNHafTE (0:23)

Steps to reproduce

  1. Cast SoL
  2. Cast Judgement
  3. Cast SoR

Version & Environment

Client Version: 1.12.1.5875

OS Client: 1.12.1.5875 OS Server: Lasted downloadable files

MrWackyPeanut commented 4 weeks ago

As I understand it, it's not Judgement of Light that has issues, but rather Seal of Righteousness.

On Kronos and Turtle, for example, you can see how Seal of Righteousness holy damage checks for "on-hit" procs. From Judgement of Light/Wisdom, to Nightfall.

Check this YouTube video out of how it works in Classic as well: https://youtu.be/BYFnjyZYfcc?t=47

MrWackyPeanut commented 4 weeks ago

image

This image shows how Seal of Command is working correctly in this aspect, and could perhaps be used as a guide to find the solution.