vmangos / core

Progressive Vanilla Core aimed at all versions from 1.2 to 1.12
GNU General Public License v2.0
692 stars 491 forks source link

Native Branch: Replace ACE/get_opt with custom ArgparseForServer #2723

Closed 0blu closed 2 months ago

0blu commented 2 months ago

🍰 Pullrequest

Replace ACE/get_opt with custom ArgparseForServer

0blu commented 2 months ago

I take some effort to make a nice git history, please dont squash merge them :(

ratkosrb commented 2 months ago

But we always squash merge in vmangos. Otherwise you can't revert cleanly, or go back to revision before I clicked merge, because the commits will be spread out. We never do regular merge in vmangos. When this branch is ready the whole native branch will be squash merged into development with commit named "Remove usage of ACE framework".

0blu commented 2 months ago

Ah okay, I see, reversion is actually useful.