vmangos / core

Progressive Vanilla Core aimed at all versions from 1.2 to 1.12
GNU General Public License v2.0
690 stars 491 forks source link

🐞 [Bug] Shaman Clearcast Consumed by Spell that Procced Clearcast #2750

Open soundbrands opened 2 months ago

soundbrands commented 2 months ago

-->

🐞 Bug report - Spell

The Clearcasting effect from the Shaman talent Elemental Focus has a chance to proc whenever a damaging spell finishes casting.

However, if the spell that procs Clearcasting has a travel time (e.g. Lightning Bolt), and if another cast is begun while that spell is still traveling, the Clearcasting proc is consumed when the spell that initially procced the clearcast lands, rather than by the next spell that is cast.

Expected behavior

Clearcasting procs when a spell finishes casting. It should make the next spell cast cost no mana. It should not be consumed by the spell that procced it, as this spell has already consumed mana and this provides no benefit.

This can be inferred from the description of the talent, which says " Gives you a 10% chance to enter a Clearcasting state after casting any Fire, Frost or Nature damage spell. The Clearcasting state reduces the mana cost of your next damage spell by 100%."

Steps to reproduce

  1. Learn the Shaman talent "Elemental Focus"
  2. Open the combat log
  3. Continously cast Lightning Bolts at a creature or target dummy that is far enough away that another cast can be begun while the bolt is traveling
  4. After a Clearcast proc, notice that when the spell that procced it lands, the combat log says "Clearcast fades from you", and that the next spell cast did not have its mana cost reduced.

Version & Environment

Client Version: 1.12.1.5875

Commit Hash: