This PR fixes several character issues in table 'locale_page_text' column 'Text_loc3' (german). Umlauts are missing and HTML is broken. HTML source code appear in the game.
Proof
Before the fix:
After the fix:
Issues
missing chars 'ä','ö','ß'.
char 'ü' upper case in some words.
broken path separators for images (backslashes where missing in some cases).
broken P-tags in HTML
How2Test
To verify the effective changes a diff on character level is recommended. Dump table 'locale_page_text' before and after applying the fix, then do:
git diff --no-index --word-diff=color --word-diff-regex=. dump_before.sql dump_after.sql
I have reviewed this fix by making a diff as describe above and checked following corner cases in-game:
Test correct HTML and image rendering (images, and formatting):
.additem 18664
.additem 18675
Test correct plain text and special char (there is a trade mark symbol inside the text):
.additem 5897
Test correct plain text containing single quotes (to check proper escape sequences in sql migration):
.additem 3921
Test correct plain text containing umlauts:
.additem 9580
🍰 Pullrequest
This PR fixes several character issues in table 'locale_page_text' column 'Text_loc3' (german). Umlauts are missing and HTML is broken. HTML source code appear in the game.
Proof
Before the fix:
After the fix:
Issues
How2Test
To verify the effective changes a diff on character level is recommended. Dump table 'locale_page_text' before and after applying the fix, then do:
git diff --no-index --word-diff=color --word-diff-regex=. dump_before.sql dump_after.sqlI have reviewed this fix by making a diff as describe above and checked following corner cases in-game:
Test correct HTML and image rendering (images, and formatting): .additem 18664 .additem 18675
Test correct plain text and special char (there is a trade mark symbol inside the text): .additem 5897
Test correct plain text containing single quotes (to check proper escape sequences in sql migration): .additem 3921
Test correct plain text containing umlauts: .additem 9580