forsaken skills

[Gamemechanicwow]

🍰 Pullrequest

Allows spell 7054 forsaken-skills to proc 7053 forsaken-skill-shadow

Proof

• From the comments following the code, it looks like 7053 was mistaken for 7052
• I have verified that all 15 spells exist in the clients from 1.2.4 to 1.12.1 - and spell 7052 exists in none of them

Issues

A different approach of fixing this, could be by using PickRandomValue().

How2Test

• None

Todo / Checklist

• [X] None

[ratkosrb]

Why is there a log statement in this function?

[Gamemechanicwow]

For no apparent reason. Let's get rid of it.

[ratkosrb]

Same spell is used in Aura::TriggerSpell btw.

[ratkosrb]

Can you move the variable declaration to the proper scope btw, no idea why its declared outside the switch case.

[0blu]

Maybe adding a comment to those ifs, so it the future someone still knows why this spellid is not valid and why we need to skip this number.