Improve cmake install path for extraction tools

vmangos / core

Progressive Vanilla Core aimed at all versions from 1.2 to 1.12

GNU General Public License v2.0

692 stars 492 forks source link

Improve cmake install path for extraction tools #2803

Closed schell244 closed 1 month ago

schell244 commented 1 month ago

🍰 Pullrequest

Copy map extraction tools into ${BIN_DIR}/Extractors folder, also copy offmesh.txt and config.json to the same location. Added a more consistent naming scheme for the tools:

Old Name	New Name
`mapextractor`	`MapExtractor`
`MoveMapGen`	`MoveMapGenerator`
`vmap_assembler`	`VMapAssembler`
`vmapextractor`	`VMapExtractor`

How to test

Compile with USE_EXTRACTORS = 1
CMakePredefinedTargets -> INSTALL
map extraction tools will be copied into Extractors folder

mserajnik commented 1 month ago

The executable names (MoveMapGen and MoveMapGen.exe) will have do be adjusted in this script too then: https://github.com/vmangos/core/blob/development/contrib/mmap/mmap_extract.py

mserajnik commented 1 month ago

Hm, how about also renaming mmap_extract.py to something more consistent? Maybe GenerateMoveMaps.py; or maybe better generate_move_maps.py if we want a different style to visually distinguish the script more from the compiled executables. Not sure what would be preferable here.