vmangos / core

Progressive Vanilla Core aimed at all versions from 1.2 to 1.12
GNU General Public License v2.0
692 stars 492 forks source link

Fix an issue were vmap extractor generates duplicate files on some systems #2833

Open Gamemechanicwow opened 1 week ago

Gamemechanicwow commented 1 week ago

🍰 Pullrequest

Vmap extractor extract modelnames from references in adt tiles and gameobjectdisplayinfo.dbc. The referenced modelnames can differ in case sensitivity. Since linux has case sensitive filnames, this will - unlike windows - not be caught by fileexists() and 1100~ duplicate files will be generated.

This PR ensures that each modelname is referenced the same way.

Proof

Issues

How2Test

Todo / Checklist

Gamemechanicwow commented 1 week ago

marked as draft because even though - the extracted model files on linux now matches windows. I still need to analyze if it has any impacts on dir_bin and temp_gameobject_models.