vmarc / knooppuntnet

Route planner and quality assurance for walking and cycling networks in OpenStreetMap.
MIT License
31 stars 6 forks source link

[Feature Request] Handling multi activities routes #214

Open pyrog opened 2 years ago

pyrog commented 2 years ago

Some hiking routes are shared with at least MTB and/or riding.

Current OSM tagging scheme support that: it use multi values in the network key (separated by ;) Example: Les trois Monts a hiking and MTB route on top of the Grand Dole node network.

type=route
route=hiking;mtb

This route is displayed in hiking and MTB WaymarkedTrails.

I changed the route tag of all shared routes of the node network, but this change raise a new fact:

RouteTagInvalid

Invalid value in required tag "route" in route relation. A bicycle route relation needs to have value "bicycle" in its "route" tag. A hiking route relation needs to have one of the following values in its "route" tag: "foot", "hiking", or "walking". Note that "walking" is a value that is frequently found, but not actually documented as a valid value in the OSM wiki pages. Other potential values are "horse", "motorboat", "canoe" and "inlineskates"*.

Note: There is 510 multi activities routes according overpass and around 410 routes according TagInfo (type ; in the search value and count manually good values)

See also #213

vmarc commented 2 years ago

The analysis logic has been changed so that RouteTagInvalid is no longer generated when the "route" tag contains multiple values separated by semicolon(s). Support for MTB routes is still a separate issue.

pyrog commented 2 years ago

Thank you 😄

Note: the facts are still visible in the history in version 2 and on the map a low zoom levels (I think the red colour will change to green in the next tiles generation)

Map Facts

vmarc commented 2 years ago

Note: the facts are still visible in the history in version 2

The fact will remain visible in the history until release v4.0 where the history of all nodes/routes/networks will be completely recalculated.

I think the red colour will change to green in the next tiles generation

Good point. Normally tagging changes processing results in immediate tile updates, but software updates do not trigger tile updates. Without action all tiles would be recalculated overnight (03:00h). I have now manually triggered tile recalculation, so the red should disappear during the next 20 minutes or so.

pyrog commented 2 years ago

Routes are green now, thanks 😄

pyrog commented 2 years ago

I checked the hiking and riding route Ctre équestre la Sauline - Les Près Gaulard

There is no fact and it is displayed on the hiking map 😄 But the route is not rendered on the riding map 😢 Hiking Riding

vmarc commented 2 years ago

But the route is not rendered on the riding map

Yes, this is because the analysis at this moment is still network based, and the route is now analyzed in the context of network "Réseau pédestre du Grand Dole" which is a hiking network. I think the analysis would not handle it well if there also was a riding network that contained that route. Analysis logic will change drastically (route based rather than network based) with the next release v4.0. I will try to make it work in that release.

pyrog commented 2 years ago

Note: multivalued tags are not fine (i.e. route=hiking;mtb)

Using tags like hiking=yes, mtb=yes… (see guideposts)