search

vmarc / knooppuntnet

Route planner and quality assurance for walking and cycling networks in OpenStreetMap.
MIT License
31 stars 6 forks source link

Render nodes without name of ref #218

Open pyrog opened 2 years ago

pyrog commented 2 years ago

Currently it seem that nodes without ref or name are tagged i.e. lwn_ref=o or 'lwn_name=o. They are not rendered with a circle.

Also, it should be simpler to remove *_ref or *_name tag 😄

Examples:

Node not rendered
pelderson commented 2 years ago

Value 0 was used in the French pilot for a Named Nodes network. These nodes should now all have lwn_name tags. The value lwn_ref=0 indicates that a node should have a number but actually doesn't. (lwn_name=0 is not defined as a special tag.) This should never happen, because the adjacent nodes should have a reference to that number. So even if the node doesn't show its number, it actually has one in the network. If the adjacent nodes do not point to this "Node" by name or number, it is in fact not a network Node! I am thinking of deprecating this special value.

vmarc commented 2 years ago

Not sure what to do. Remove all logic for nodes with name "o", or leave as-is?

These are the nodes with name "o" that are still active in the database:

nr country networkType node
1 nl motorboat 821709393
2 nl motorboat 1128054850
3 nl canoe 1230371430
4 nl canoe 1230371437
5 nl canoe 1230371592
6 nl canoe 1230371670
7 nl canoe 1230371716
8 nl canoe 5792019559
9 nl canoe 5792063837
10 nl canoe 5792117624
11 fr hiking 571149119
12 fr hiking 1177396735
13 fr hiking 1177397318
14 fr hiking 1177397530
15 fr hiking 1794382656
16 fr hiking 312452089
17 fr hiking 1894929616
18 fr hiking 364534730
19 fr hiking 2451887143
20 fr hiking 660862408
21 fr hiking 4219868338
22 fr hiking 1738571718
pyrog commented 2 years ago

Remove all logic for nodes with name "o"

👍