vmarc / knooppuntnet

Route planner and quality assurance for walking and cycling networks in OpenStreetMap.
MIT License
31 stars 6 forks source link

Possible bug in Monitor for some patterns of sub-relations #345

Open StC-OSM opened 10 months ago

StC-OSM commented 10 months ago

The French part of E7 (https://knooppuntnet.nl/fr/monitor/groups/eu-iwn-E-paths/routes/E7) has discontinuities in the Monitor function, which I suspect are triggered by the peculiar structure of sub-relation Merindol-Montjustin (https://www.openstreetmap.org/relation/11896633): a series of paths, a series of sub-relations from a node network, another series of paths; see the attached picture from the JOSM relation editor

image

vmarc commented 10 months ago

Yes, when coding the gap analysis logic, I did not anticipate that ways and sub-relations would be mixed in the same superrelation. I will look into this. This will also further complicate the way the maps per subrelation are shown, so perhaps something fundamental needs to change in order to make this work.

Also: a questionmark is shown for the sub-relations of "Merindol - Montjustin". The value in the "ref" should be shown here.

vmarc commented 10 months ago

Monitor routes that have relations with both ways and relations are a bit more common than I thought:

route relations
1 SGR:GR-16 197843 : GR 16 Sentier de la Semois
2 eu-iwn-E-paths:E1 297398 : European long distance path E1 - part Denmark
36367 : European long distance path E1 - part Germany
2096494 : European Long distance path E1 - part Germany, Reinland-Pfalz (North)
3 eu-iwn-E-paths:E2 east 1976183 : European walking route E2, UK, East of England
1956165 : GR 5 Vosges
6095322 : GR 5 Jura
2704286 : Grande Traversée des Alpes
4 eu-iwn-E-paths:E2 west 1976229 : European walking route E2 west, UK, South East England
1956165 : GR 5 Vosges
6095322 : GR 5 Jura
2704286 : Grande Traversée des Alpes
5 eu-iwn-E-paths:E3 6585178 : European long distance path E3 - part Belgium
6177257 : European long distance path E3 - part Czech Republic, North West
6 eu-iwn-E-paths:E4 1157562 : Europäischer Fernwanderweg E4, Österreich
14405401 : E4: Sokobanja – Jalovik izvor
2376439 : European long distance path E4 - part Greece
2376091 : European long distance path E4 - part Cyprus
7 eu-iwn-E-paths:E5 12771763 : Bagnoles-de-l'Orne — Avranches
8 eu-iwn-E-paths:E7 3353827 : European long distance path E7 - part Spain
3386433 : European long distance path E7 - part Spain (Mainland)
6171552 : GR-131 Camino Natural de Lanzarote
11896633 : Merindol - Montjustin
9 eu-iwn-E-paths:E9 7790332 : Chemin des Douaniers
1959386 : European long distance path E9 - part alternative Great Britain
16051055 : Two Bays Way
1959052 : Europäischer Fernwanderweg E9, Deutschland, Schleswig-Holstein
10 eu-iwn-GR:GR 16 197843 : GR 16 Sentier de la Semois
11 eu-iwn-GR:GR 5 1956165 : GR 5 Vosges
6095322 : GR 5 Jura
2704286 : Grande Traversée des Alpes
12 fr-iwn-Camino:Via-Arverna 3370909 : VA 01 : Clermont-Ferrand - Olloix
3371123 : VA 02 : Olloix - Issoire
3371244 : VA 03 : Issoire - Jumeaux
3371314 : VA 08 : Ferrières-Saint-Mary - Neussargues-Moissac
3371448 : VA 09 : Neussargues-Moissac - Murat
3371582 : VA 10 : Murat - Saint-Jacques-des-Blats
13 fr-iwn-Camino:Voie-Toulouse 14995844 : Voie d'Arles, accès aux sites
14 fr-iwn-European:E2 1956165 : GR 5 Vosges
6095322 : GR 5 Jura
2704286 : Grande Traversée des Alpes
15 fr-iwn-European:E5 12771763 : Bagnoles-de-l'Orne — Avranches
16 fr-iwn-European:E7 11896633 : Merindol - Montjustin
17 fr-iwn-European:IW 10796782 : Interregio-Wanderweg (schweizer Abschnitt)
18 fr-nwn:GR 11 12873215 : Grand Tour de Paris (10), Montereau - Fontainebleau
19 fr-nwn:GR 124 8313229 : De Cires-lès-Mello à Ailly-sur-Noye
20 fr-nwn:GR 22 12771763 : Bagnoles-de-l'Orne — Avranches
21 fr-nwn:GR 4 13048526 : Saint-Martin-d'Ardèche — Monjustin
22 fr-nwn:GR 5 2704286 : Grande Traversée des Alpes
23 fr-nwn:GR 70 7501585 : Chemin de Stevenson - Part 9
24 fr-nwn:GR 9 11173071 : Buis-les-Baronnies — Cucuron
11173072 : Cucuron — Saint-Zacharie
25 fr-nwn:GR 9-07 11173071 : Buis-les-Baronnies — Cucuron
26 fr-nwn:GR 9-08 11173072 : Cucuron — Saint-Zacharie
27 fr-nwn:GR BL 5183682 : Balcon du Léman
28 fr-nwn:GR42 2410123 : De Saint-Étienne au Grau-du-Roi
29 fr-rwn:LLPC 9417164 : Entre Loue et Lison au Pays de Courbet
30 fr-rwn:Revermont 2784835 : Tour du Revermont
31 fr-rwn:TP-Allevard 16068030 : Refuge de la Pierre du Carre — Refuge de l’Oule
16068028 : Gîte de la Martinette — Refuge du Crêt du Poulet
32 fr-rwn:TPAA 16527940 : Tour du Pays des Aiguilles d'Arves (étape 1)
16527958 : Tour du Pays des Aiguilles d'Arves (étape 2)
16528099 : Tour du Pays des Aiguilles d'Arves (étape 5)
16502889 : Tour du Pays des Aiguilles d'Arves (étape 6)
16527401 : Tour du Pays des Aiguilles d'Arves (étape 7)
33 fr-rwn:TPAA-test 16527940 : Tour du Pays des Aiguilles d'Arves (étape 1)
16527958 : Tour du Pays des Aiguilles d'Arves (étape 2)
16528099 : Tour du Pays des Aiguilles d'Arves (étape 5)
16502889 : Tour du Pays des Aiguilles d'Arves (étape 6)
16527401 : Tour du Pays des Aiguilles d'Arves (étape 7)
34 fr-rwn:TPAA-test gpx 16527940 : Tour du Pays des Aiguilles d'Arves (étape 1)
16527958 : Tour du Pays des Aiguilles d'Arves (étape 2)
16528099 : Tour du Pays des Aiguilles d'Arves (étape 5)
16502889 : Tour du Pays des Aiguilles d'Arves (étape 6)
16527401 : Tour du Pays des Aiguilles d'Arves (étape 7)
35 fr-rwn:Tour-Omois 5469213 : Tour de l'Omois
36 fr-rwn:Valserine 13672688 : Grand Tour de la Valserine
StC-OSM commented 10 months ago

In my experience it corresponds either to temporary situations (e.g. incomplete route restructuring) or to borderline situations (e.g. one route that contains another route except for its few first hundred meters). We could attempt to ban it but then we would need to provide recommendations for said borderline situations.

pyrog commented 10 months ago

Also: a questionmark is shown for the sub-relations of "Merindol - Montjustin". The value in the "ref" should be shown here.

In fact logic for node network routes should be reused (at least for "labelling" routes).