search

vmarchesin / react-konami-code

Trigger an easter egg by pressing a sequence of keys.
MIT License
59 stars 13 forks source link

react, react-dom and prop-types shouldn't be dependencies #20

Closed VitorLuizC closed 3 years ago

VitorLuizC commented 3 years ago

I've upgraded to react@17.0.1 and got an Invalid hook call error on useKonami.

Screenshot with "Invalid hook call" error

Seems like this package requires react and react-dom as dependencies.

npm ls react
candidate-area-client@0.1.0 /home/vitorluizc/projects/trybe/student-journey-client
├── UNMET PEER DEPENDENCY react@17.0.1 
└─┬ react-konami-code@2.0.1-beta.1
  └── react@16.14.0 

npm ERR! peer dep missing: react@^0.14 || ^15 || ^16, required by html-react-parser@0.13.0
npm ERR! peer dep missing: react@^16.0.0, required by react-heroicons-ui@1.0.2
npm ERR! peer dep missing: react@^16.8.0, required by react-hook-form@5.7.2
npm ERR! peer dep missing: react@^16.13.1, required by react-konami-code@2.0.1-beta.1
npm ERR! peer dep missing: react@^0.14.7 || ^15.0.0 || ^16.0.0, required by react-lottie@1.2.3
npm ERR! peer dep missing: react@^0.14.0 || ^15.0.0 || ^16.0.0, required by react-text-mask@5.4.3

But it shouldn't. react and react-dom should be required in peerDependencies, and just imported as devDependency if you need to run tests, example etc.

It also throws an error because React.js 17 don't match react peer dependency range. But it doesn't seem to break with it.

https://github.com/vmarchesin/react-konami-code/blob/a3278a801a92f8bcd92fc43eae51164954bb6e37/package.json#L68-L71