vmarchesin / react-konami-code

Trigger an easter egg by pressing a sequence of keys.
MIT License
62 stars 12 forks source link

Migrate library to TypeScript #22

Closed mechamobau closed 3 years ago

mechamobau commented 3 years ago

This Pull Request has been created to migrate the library to the TypeScript language. So, a few things have changed, but keeping all functionality of the lib:

I've made this change only for study reasons, but I'm opening this PR to know if this can help the library.

mechamobau commented 3 years ago

@vmarchesin All tests passing and build working according to the expected. If you see another wrong thing, please tell me that I'll fix it ;)

vmarchesin commented 3 years ago

I tested it and it seems to be working as expected. I wasn't planning on updating this to TS but since you already went through the trouble of doing it it looks good. I'll publish a new version soon.

Thank you for the contribution :)

vmarchesin commented 3 years ago

Version 2.2.0 is released. I made some minor changes and added a very useful render optimisation that I forgot to put in place when I first created the package. The example folder should be up to date as well. Thanks again, everything seems to be in place.