vmarchesin / react-konami-code

Trigger an easter egg by pressing a sequence of keys.
MIT License
59 stars 13 forks source link

Create const file with defaults #23

Closed eliamartani closed 3 years ago

eliamartani commented 3 years ago

This pull request is intended to simplify usage of common variables in one place.

The idea came after checking that Konami code [38, 38, 40, 40, 37, 39, 37, 39, 66, 65] was being used in more than 1 place as default. The idea is to simplify by making const.ts a common file for constant variables.

vmarchesin commented 3 years ago

Hey, I'll probably merge this later when I test it. Honestly wasn't a big deal as this is just one array that's being repeated.