search

vmatare / thinkfan

The minimalist fan control program
GNU General Public License v3.0
541 stars 62 forks source link

optional parameter is ignored in deamon mode #161

Closed monosoul closed 2 years ago

monosoul commented 2 years ago

OS: ubuntu 21.10 Kernel: 5.13 Thinkfan version: 1.2.1

When running thinkfan in daemon mode it fails to start with:

ERROR: read_temps: Failed to read temperature(s) from /sys/class/hwmon/hwmon4/temp2_input: No such device or address

Even though the sensor is marked as optional.

If I run thinkfan with -n argument in interactive mode, it works while printing error messages.

monosoul commented 2 years ago

Had to workaround it by using /proc/acpi/ibm/thermal where sensors are never missing, but have negative values instead.

vmatare commented 2 years ago

Thinkfan 1.2.1 has a bug in the way the optional keyword is handled, which should have been fixed in 1.2.2. I've also just published the 1.3.0 release which has further improvements to config handling. The best you could do is report this as a bug against the thinkfan Ubuntu package and get them to update thinkfan. If that doesn't work, the next best thing you can do is probably to download the latest release from github and compile & install it yourself.

monosoul commented 2 years ago

Hey Victor, thanks for the reply! I had to switch to Fedora recently since Ubuntu's kernel was acting weird on my hardware. And Fedora's repo has thinkfan 1.2.2 there, so everything works just fine now.