search

vmatare / thinkfan

The minimalist fan control program
GNU General Public License v3.0
534 stars 61 forks source link

Fix build on RISC-V #220

Closed leegarrett closed 1 year ago

leegarrett commented 1 year ago

Not sure if RISC-V hardware exists that could benefit from running thinkfan, but let's make it build there already.

vmatare commented 1 year ago

Hey... sorry about the late reply, but I'm wondering, if you don't know of any specific RISC-V hardware you want to run thinkfan on, then how did this even come up and why would you want it?

leegarrett commented 1 year ago

Indeed, so far I'm not aware of any RISC-V hardware that could benefit from thinkfan, but I also didn't do any research whatsoever. The patch was proposed on the Debian bug tracking system by two different users. IMHO the patch is trivial and would make it work out of the box for such HW (if it already exists or might in the near future).

Ultimately it's your call, I'm happy with either option (it being merged or not).

leegarrett commented 1 year ago

Third option: Leave this MR open until someone with actual HW benefitting from this wants it merged. :)