search

vmax1145 / BitrateEditor

17 stars 0 forks source link

SJCAM SJ8 Pro: found another Chroma table for FHD videos in adj_video_default_02_Imx377 #8

Open RigacciOrg opened 2 years ago

RigacciOrg commented 2 years ago

In file adj_video_default_02_Imx377 there is a Chroma table at the same offset of the adj_video_default_00_Imx377 file. Both tables contain the same numeric values (firmware 1.3.2). I changed all the values to zero, so I obtained grayscale videos. That chroma table applies to the images displayed on the touchscreen and on the following video modes:

The other video modes are NOT affected: 720@240, 1080@120, 4K@25,30,50,60.

vmax1145 commented 2 years ago

Look here https://github.com/vmax1145/BitrateEditor/blob/8018f837f4aa8f8c342fbac21f80761c1c4ae5b4/config-SJ8-SJ9/gamma.json#L186

This gamma tables already present in config-SJ8-SJ9/gamma.json under FHD60 label used in SJ8Pro.gamma.bat

RigacciOrg commented 2 years ago

This is a Chroma table, not Gamma. I tried to extend config-SJ8-SJ9/chroma.json, adjusting just label and filename. It worked.

RigacciOrg commented 2 years ago

I see that the same tables are also in files adj_video_default_01_Imx377 and adj_video_default_03_Imx377. So I suspect that chroma tables are stored and used the same as gamma tables, i.e. different resolutions/fps uses different tables from different files.

vmax1145 commented 2 years ago

Oppps... ;) You are right And ... as sqim discovered with sharpeness filters _00 - 4K@50/60 _01 - 4K@25/30 _03 - FHD@120 _04 - HD@240 _02 - others Chroma may use same rules

RigacciOrg commented 2 years ago

I made some extensive tests, the following are the chroma tables used:

adj_video_default_00_Imx377, offset 0x74F4

adj_video_default_01_Imx377, offset 0x74F4

adj_video_default_02_Imx377, offset 0x74F4

adj_video_default_03_Imx377, offset 0x74F4

adj_video_default_04_Imx377, offset 0x74F4

adj_still_default_00_Imx377, offset 0xA63C

adj_hiso_still_default_00_Imx377, offset 0xA63C

It is hard to think about sensible labels to be assigned into BitrateEditor. Listing all the video modes associated with one table produces very very long labels. This may be a short version: 4K60, 4K30, FHD, 1080@120, 720@240, Photo, Photo-Hi-ISO. I attach a proposed new file chroma.json, but labels should be reviewed by the author v_max.

vmax1145 commented 2 years ago

Great... but if I remember right usage of adj_videodefault** files may also also depends on codec choice h264 or h265 So ... with which codeс in settings you did this tests?