search

vmayoral / ros-robotics-companies

A list of robotics companies using the Robot Operating System (ROS and ROS 2).
1.29k stars 177 forks source link

Correct phrasing "company X uses Y in Z" (Manipulation section) #75

Closed gavanderhoorn closed 1 year ago

gavanderhoorn commented 1 year ago

As mentioned in #74 (and examples in #73 and #72), the phrasing

The company uses the ROS Manipulation stack (MoveIt) in X

appears in quite a few places in the list, specifically the Manipulation section.

For at least the companies where references are made to repositories under the ros-industrial GitHub organisation, none of these claims are correct.

This could be just the exact wording of the sentence, so perhaps just rephrasing it to something like "there are configuration packages for MoveIt available for the product of company Y" would be more correct. But I guess that wouldn't work, as it would put the bar very low for companies to appear on the list.

vmayoral commented 1 year ago

This could be just the exact wording of the sentence, so perhaps just rephrasing it to something like "there are configuration packages for MoveIt available for the product of company Y" would be more correct. But I guess that wouldn't work, as it would put the bar very low for companies to appear on the list.

I think we should agree on a criteria and be consistent with it. I'd say once we address https://github.com/vmayoral/ros-robotics-companies/issues/74, we should make a pass and try to be consistent with it. If companies don't meet the criteria, then they should be removed.

vmayoral commented 1 year ago

Criteria has been set.

@pabloaccelerationrobotics, I believe you'll go through the list and address the concern raised above, right? Can you report in here once you've done that so that we try resolving this ticket?

vmayoral commented 1 year ago

@pabloaccelerationrobotics where are we with this? Did you manage to find time on your end and look at the list while following the criteria?

vmayoral commented 1 year ago

@pabloaccelerationrobotics ping in here. Please let us know once you finish the review so that we can make another pass.

pabloaccelerationrobotics commented 1 year ago

The review of the list is already finished. Following the new criteria, I have changed the justification for why some companies were on the list. The companies that I have not found justification have been eliminated.

@vmayoral and @gavanderhoorn Can you review it?

gavanderhoorn commented 1 year ago

I don't really have time to go through all changes, but I did a spot check and I noticed you seemingly reverted some fixes that were made as a result of our earlier discussions.

See here fi, which basically reinstates Robotiq as a "ROS using/supporting company".

vmayoral commented 1 year ago

See here fi, which basically reinstates Robotiq as a "ROS using/supporting company".

Reverted changes for Robotiq https://github.com/vmayoral/ros-robotics-companies/commit/f795e7e230520da654518e583544955aff99f197.

Thanks for the review @pabloaccelerationrobotics. Feel free to point out any further defects if you have time @gavanderhoorn.