vmc-project / vmc

The Virtual Monte Carlo core library.
GNU General Public License v3.0
7 stars 10 forks source link

Updated cmake: Do not allow build against ROOT compiled with vmc enabled #13

Closed ihrivnac closed 2 years ago

ihrivnac commented 2 years ago

This resolves issue pointed in https://github.com/FairRootGroup/FairRoot/pull/1123

benedikt-voelkel commented 2 years ago

Hej @ihrivnac Thanks a lot! is it possible that you rebase on top of master? At the moment it seems you started from a much earlier commit. Let me know, I can also do it quickly and add to the PR

benedikt-voelkel commented 2 years ago

I also tested, it happily fails when ROOT has internal VMC present and I can build otherwise

benedikt-voelkel commented 2 years ago

Ok, I can confirm both the failing with ROOT's VMC enabled and the successful build of VMC when ROOT's VMC is disabled. Good to be merged from my side

ihrivnac commented 2 years ago

Thanks @dennisklein and @benedikt-voelkel for checking