Make Header Paths in Dictionary Relative

vmc-project / vmc

The Virtual Monte Carlo core library.

GNU General Public License v3.0

7 stars 10 forks source link

Make Header Paths in Dictionary Relative #8

Closed ChristianTackeGSI closed 4 years ago

ChristianTackeGSI commented 4 years ago

(I am working in the SDE group at GSI with @MohammadAlTurany and I am currently improving our packaging of vmc.)

According to these root release notes the listed headers in ROOT_GENERATE_DICTIONARY should use relative paths.

Before this change, the headers are loaded from the source/build tree. If the source/build tree is removed after installation, the headers are not found any more.

With this change, the headers in the install tree are found by the interpreter, when ROOT_INCLUDE_PATH is set.

ihrivnac commented 4 years ago

@ChristianTackeGSI , Thank you for this fix. There is already a related issue https://github.com/vmc-project/geant4_vmc/issues/13 where several solutions are proposed. You are welcome to contribute here with your opinion.

ChristianTackeGSI commented 4 years ago

Thanks for the invitation! I will read up on that discussion and see, if I can contribute something useful.

The quick note: The proposed patch in this PR should not break anything (that wasn't already broekn). So it shouldn't hurt.

ChristianTackeGSI commented 4 years ago

Added changes, as discussed in https://github.com/vmc-project/geant4_vmc/issues/13