search

vmcpherson / googlemock

Automatically exported from code.google.com/p/googlemock
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

comma at end of enums #138

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
in file 
gmock-spec-builders.h

What steps will reproduce the problem?
1.  Compile with  -pedantic (gcc)
2.
3.

What is the expected output? What do you see instead?

Which version of Google Mock are you using? On what operating system?
From trunk

Please provide any additional information below.
This is illegal c++ as far as I can see, it seems allowed in c99 so may make 
c++0x or whatever it will be called, but it's not currently legal.

Original issue reported on code.google.com by irvine.d...@gmail.com on 28 Mar 2011 at 10:57

GoogleCodeExporter commented 9 years ago 
Could you please post the error messages you got?  Thanks.

Original comment by w...@google.com on 28 Mar 2011 at 11:32

GoogleCodeExporter commented 9 years ago 
No worries, nothing startling really. 
installed/include/gmock/gmock-spec-builders.h:598:25: error: comma at end of 
enumerator list

There is a comma there :-) I think glog also has this kind of thing kicking 
about.

Original comment by irvine.d...@gmail.com on 28 Mar 2011 at 11:36

GoogleCodeExporter commented 9 years ago 
It's not a showstopper for us, we use -isystem on most of this anyway, but it 
is a relatively easy fix so hopefully this is helpful.

Original comment by irvine.d...@gmail.com on 28 Mar 2011 at 11:40

GoogleCodeExporter commented 9 years ago 
Fixed in r378.

Original comment by vladlosev on 8 Apr 2011 at 1:34