search

vmeoc / Tito

https://www.vmcloud.fr
17 stars 20 forks source link

Update/Optimize Dockerfile and docker-compose #7

Closed burkeazbill closed 5 years ago

burkeazbill commented 5 years ago

I worked with Brandon to confirm his changes will benefit the project. Prior to these changes, docker-compose was not ideal since it was static copies of images from docker hub. It now properly builds from source based on the Dockerfile definitions for tito-fe and tito-sql. Also, cleaned up some of the code. I have personally validated these files locally as well as on Cloud PKS using images built from source.

burkeazbill commented 5 years ago

Wait on this merge - the switch from mysql to maria resulted in logs every second attempting to do healthcheck with a command that no longer works.. the app all works, but I'll get this resolved first, then we can merge.

burkeazbill commented 5 years ago

Ok, 756718a fixes that minor issue.. code should be ready for you to merge now. We are in the process on working on some additional changes/updates ;)

vmeoc commented 5 years ago

Thanks Burke. Good to have this done more dynamically now