puremana
commented
1 year ago @vmeow I don't know if I even want to tag you... so feel free to just skip this if you want. I won't mind in the slightest.
But if you did want to review the PR briefly as this is my first time adjusting rates, that would be lovely (although as I said, happy if you ignore also!). Like the description says these changes are live on dev site and won't push live for a few days probably. Once I push code live, I will run code below to update EHP.
Player.where("overall_ehp > 250 OR player_name IN #{Player.sql_supporters}").find_in_batches(batch_size: 25) do |batch| batch.each do |player| begin player.recalculate_ehp player.recalculate_current_ehp rescue next end end end
This is majority of changes, but may do smaller polls and UI changes after this is updated
Needing to test on dev still.
Edit: Dev link https://f2pehp2.herokuapp.com/. Currently being tested by players in f2p skilling methods discord. Currently good feedback regarding actual rates working, but UI on ehp page could be more clear because of all of the bonus xp listings and no videos showing methods.