vmeow / f2pehp

BSD 3-Clause "New" or "Revised" License
16 stars 12 forks source link

Monster Ratio: Fixed Runecraft XP rates for Golems and Minotaurs #173

Open SheungLu opened 1 month ago

SheungLu commented 1 month ago

Fixed Golem (Flawed, Mind, Body) runecraft xp rates. Minotaur essence xp formula is same as Golem runecraft xp formula since bone fragments from skull-half drops outpace the noted essence drops. (skull halves drop 3 bone fragments and each fragment is used with 25 noted essence per lap) Minotaur gem drop rates have also been updated.

puremana commented 1 month ago

Hey! I really appreciate the proposed fixes for wiki, thanks so much for spending your time on this.

From a code point of view, it looks fine obviously, but I'm not that familiar with the XP ratios of Minotaurs and going from runecraftper1 = 16.707920792; to runecraftper1 = 1.856435644; is a huge change.

I'm going to forward this PR to @tannerdino to review, as he was the one to implement those in the first place and rely on his feedback on the next steps for this PR.

Thanks again!

tannerdino commented 1 month ago

Its true the noted ess is 0 time, but the runecraftper1 is assuming you use the sceptre pieces for rc (sceptre body runes). The idea of killing minotaurs in the first place is for sceptre pieces to use for rc, so a lot of combat calculations revolve around the rc xp from sceptre pieces.

Could add a sceptre body runes method to rc, and then include rc xp from sceptre pieces if the user selects that method. Just make sure the noted ess isnt included in the sceptre body runes runecraftper1.

SheungLu commented 1 month ago

Hi tannerdino, big fan! I'm fine with whatever changes you would like to make. Yeah, maybe scepter pieces should have their own category in runecraft xp. The Golem runecraft xp calculations seem to also assume using the noted essence for body runecrafting, and that method uses scepter teleports (which Golems don't drop). It would be interesting to tweak the calculator to suggest a combination of golems and Minotaurs to effectively use the combined noted essence and skull-half drops from both, but maybe that's outside of the scope of this calculator.