vmeretail / subscriptionservice

Lightweight and easy to use library, which allows you to manage you delivering events from persistent subscriptions.
12 stars 0 forks source link

Internal implementation of Subscription #29

Closed StevenBlair123 closed 4 years ago

StevenBlair123 commented 4 years ago

Is your feature request related to a problem? Please describe. At the moment, the caller has access to Subscription, which is a Value object. I suspect internally, we will want to hold more things alongside a Subscription (for example a HttpClient)

Describe the solution you'd like A new internal implementation of Subscription (probably more like a domain model, rather than a VO). The internal Subscription will be created in the SubscriptionService ctor (possibly via a factory).

Describe alternatives you've considered Keep the code as is, but at some point we will want extra items in the Subscription, so either we keep adding to the Subscriptino VO, or create a new related item internally, which has a reference to this public facing one.