search

vmg / rinku

Autolinking. Ruby. Yes, that's pretty much it.
ISC License
597 stars 67 forks source link

The great UTF8 Refactoring #52

Closed vmg closed 8 years ago

vmg commented 8 years ago

Here it is. The long awaited UTF8 compatibility refactoring. This new autolinking implementation is now UTF8 aware, and should handle all previously reported encoding-related bugs and corner cases.

It also includes fixes for mixed encodings, better handling of strings with bad encodings, and fixes for small autolinking bugs (like hash-encoded unicode entities at the end of a link, or case-sensitive WWW prefixes).

I've backported all of @kerrizor's tests and written a bunch of new ones. 👌

Fixes https://github.com/vmg/rinku/issues/50 Fixes https://github.com/vmg/rinku/issues/39

Fixes https://github.com/vmg/rinku/pull/51 Fixes https://github.com/vmg/rinku/pull/43 Fixes https://github.com/vmg/rinku/pull/42 Fixes https://github.com/vmg/rinku/pull/28 Fixes https://github.com/vmg/rinku/pull/44

grosser commented 8 years ago

😍

magnusvk commented 8 years ago

Does the 2.0.0 gem release contain these changes?

magnusvk commented 8 years ago

It appears so; it fixes our UTF issue, at least. 😄 Thanks for the update.

vmg commented 8 years ago

You're welcome. The 2.0.0 release does indeed contain all these changes, and fixes all the known UTF issues. Please report anything I might have missed! :)