Use tag_builder for Rails support in >5.1.0

vmg / rinku

Autolinking. Ruby. Yes, that's pretty much it.

ISC License

599 stars 67 forks source link

Use tag_builder for Rails support in >5.1.0 #71

Closed Floppy closed 5 years ago

Floppy commented 7 years ago

This will resolve #70.

Only concern with this is that it will break in Rails <5, and rinku doesn't specify any rails dependency versions. That's up to the maintainers to work out though I think. Personally I'd specify rails_rinku as a separate gem that has this code in it, and specifies rails versions properly, but it's up to you.

kivikakk commented 7 years ago

Hrm. Would it be possible to conditionally invoke tag_builder if present, so as to retain backwards-compat support with the least work? I don't really mind dropping compatibility with old Rails versions myself, but seeing as Rails 5 is still less than a year old (heh), I think it might be worth hanging onto for a bit.