search

vmg / rinku

Autolinking. Ruby. Yes, that's pretty much it.
ISC License
599 stars 67 forks source link

Fix use of tag_builder for Rails >= 5.1 #74

Closed watsonbox closed 6 years ago

watsonbox commented 6 years ago

A slight reworking of https://github.com/vmg/rinku/pull/71 which supports both Rails 5 and Rails 5.1, as requested.

tbuehl commented 6 years ago

Thanks for the PR! I added a comment to simplify the Rails version check.

watsonbox commented 6 years ago

@tbuehl Thanks for the feedback 👍 . I kind of thought it might be better to restrict the gem itself to <= 5.1 rather than predict the future, but it's true it's more flexible like this. I updated with Gem::Version for the comparison though, since "10.0.0" < "5.1".

kivikakk commented 6 years ago

Thank you! :heart:

tbuehl commented 6 years ago

Good catch on the "10.0.0" comparison. Thanks for fixing this!