Closed watsonbox closed 6 years ago
Thanks for the PR! I added a comment to simplify the Rails version check.
@tbuehl Thanks for the feedback 👍 . I kind of thought it might be better to restrict the gem itself to <= 5.1 rather than predict the future, but it's true it's more flexible like this. I updated with Gem::Version
for the comparison though, since "10.0.0" < "5.1"
.
Thank you! :heart:
Good catch on the "10.0.0"
comparison. Thanks for fixing this!
A slight reworking of https://github.com/vmg/rinku/pull/71 which supports both Rails 5 and Rails 5.1, as requested.