search

vmg / rinku

Autolinking. Ruby. Yes, that's pretty much it.
ISC License
596 stars 67 forks source link

JRuby support #75

Open headius opened 6 years ago

headius commented 6 years ago

Would you be opposed to including equivalent extension code for JRuby? The port should be pretty straightforward: I have done similar for other small extensions like Psych and the code can be nearly a 1:1 match.

rinku is a direct dependency of Discourse, which we would like to support on JRuby.

kivikakk commented 6 years ago

I would absolutely not be opposed, this would be a delightful addition.

One thing I should mention is that I lack experience with JRuby itself, so I might need to delegate maintenance (if any — this library is pretty stable) to the community.

If this is fine with you, then by all means!

headius commented 6 years ago

That seems reasonable to me. I will start a port on a fork and we'll see if we can bang this out!

headius commented 6 years ago

I started doing a port, but then realized it may be easier to wrap an existing library and just make it match rinku's API. So I started that process here: https://github.com/robinst/autolink-java/issues/20

The autolink-java library says in its README that it is "inspired by rinku" so I'm hoping the mapping will be pretty close.

kivikakk commented 6 years ago

:+1: Neat! Let me know how that goes/if I can give any more assistance on this side!