search

vmg / rinku

Autolinking. Ruby. Yes, that's pretty much it.
ISC License
599 stars 67 forks source link

Autolink sftp and ftps protocols #80

Closed marius-balteanu closed 5 years ago

marius-balteanu commented 6 years ago

Currently, only ftp protocol is auto linked. This PR is adding also sftp and ftps protocols.

Also, is adding a test for the ftp protocol.

marius-balteanu commented 5 years ago

@kivikakk, is there anything I can do in order to have this PR accepted?

marius-balteanu commented 5 years ago

A little bit of context, I made a quick integration of this library in Redmine in order to switch from the custom implementation of auto link (https://github.com/redmine/redmine/blob/master/lib/redmine/wiki_formatting.rb#L135) and when I ran the test suite I've observed that these protocols are not auto linked as Redmine already supports them.

kivikakk commented 5 years ago

Rinku is essentially in maintenance mode -- at this stage we're not accepting new features or changes in behaviour that aren't bug fixes as we're unwilling to provide ongoing maintenance support for them. I'd suggest forking!

marius-balteanu commented 5 years ago

I didn't know this, thanks for your response!