search

vmg / sundown

Standards compliant, fast, secure markdown processing library in C
1.99k stars 385 forks source link

add extern C declarations when using c++ compiler #103

Closed jjallaire closed 12 years ago

jjallaire commented 12 years ago

Conditionally added extern "C" block around declarations in header files (this only occurs when building with a c++ compiler). Without this it's inconvenient (but not impossible) to embed sundown in a C++ program. See here for additional discussion: http://www.parashift.com/c++-faq-lite/mixing-c-and-cpp.html#faq-32.4

vmg commented 12 years ago

Nice addition. Did you really mean to push the second commit?

jjallaire commented 12 years ago

No I didn't -- sorry about that! I (no idea how that happened). What is the most straightforward way to back that commit out of the pull request?

vmg commented 12 years ago

If you drop the commit from your branch, and do a push --force, it'll disappear. :)

jjallaire commented 12 years ago

I think the problem may have been that I initiated the pull request from the master branch. I'll close this request and then send another one from it's own branch.

2012/4/4 Vicent Martí reply@reply.github.com:

If you drop the commit from your branch, and do a push --force, it'll disappear. :)

Reply to this email directly or view it on GitHub: https://github.com/tanoku/sundown/pull/103#issuecomment-4961144

jjallaire commented 12 years ago

Closing -- will resubmitted from a dedicated branch