search

vmg / sundown

Standards compliant, fast, secure markdown processing library in C
1.99k stars 385 forks source link

Add nmake build target for windows. #108

Closed txdv closed 12 years ago

txdv commented 12 years ago

One can now use nmake like that: nmake /F Makefile.win to build sundown.exe and sundown.dll easily on windows.

I had to add the MD_EXTERN define to expose the functions in the dll. Tanoku I would like to hear some comments.

vmg commented 12 years ago

You forgot to add the Makefile. :)

Also: buffer.h is not the right place to add those defines, and markdown.h neither, because there's an ugly dependency here... We need to come up with a better way.

txdv commented 12 years ago

There it is. Not as beautiful as the unix makefile, yet more beautiful compared to the awful thousand vsproj files.

can't add smartypants because of getopt.h not being present on windows.

vmg commented 12 years ago

Looks good. But we still need to find a proper place for the MD_EXTERN macro. buffer.c is certainly not the place.

If I'm not mistaken, you can specify the exported symbols for a Windows DLL on an exports file; that'd drop the requirement for the macro.

txdv commented 12 years ago

One shouldn't use -a too often.

txdv commented 12 years ago

I will look into this, I have never done extensive development on windows. Thanks for the suggestion.

txdv commented 12 years ago

Here we got, I squashed them together so it is one nice tidy commit. Amazing, no need for source code change at all!

vmg commented 12 years ago

YEY! Brilliant job!