vmi / selenese-runner-java

Selenium IDE native format (selenese and side) interpreter.
Other
140 stars 82 forks source link

Real entire page screenshot support #276

Closed koichirok closed 6 years ago

koichirok commented 6 years ago

This PR contains following changes:

  1. Make captureEntirePageScreenshot take screenshot for "entire page"
  2. Make --screenshot-on-fail take "entire page" screenshot. I believe full page screenshot is quite useful for this option.
  3. Add --screenshot-scroll-timeout option to specify scroll timeout while taking screenshot for entire page

I'm not sure if --screenshot-scroll-timeout is necessary or not, because my small tests with latest Firefox, Chrome and IE (with their latest WebDrivers) didn't need this option.

However, as mentioned in Shutterbug's Examples of usage page, there are some environment that need 500 ms of scroll timeout for taking full page screenshot in Chrome. This option will be useful in such a case.

vmi commented 6 years ago

Thank you for PR!