vmi / selenese-runner-java

Selenium IDE native format (selenese and side) interpreter.
Other
140 stars 83 forks source link

Runner.setupMaxTimeTimer() should be public #309

Closed shenlian8 closed 5 years ago

shenlian8 commented 5 years ago

Hi,

the access modifier of function Runner.setupMaxTimeTimer() is default.

/**
 * Setup MaxTimeActiveTimer.
 * @param maxTime the maxTime in milliseconds.
 */
void setupMaxTimeTimer(long maxTime) {
    this.maxTimeTimer = new MaxTimeActiveTimer(maxTime);
}

As I am using this function in another package would you please change this function in public, like other functions.

It should be nice if you can make the change from 3.24.

Thanks!

Lian

vmi commented 5 years ago

Hi,

I made Runner#setupMaxTimeTimer() public, and released 3.27.1. Please check it.

shenlian8 commented 5 years ago

Yes it works. Thanks!