vmi / selenese-runner-java

Selenium IDE native format (selenese and side) interpreter.
Other
140 stars 82 forks source link

Exclude unused dependencies #313

Closed cesarsotovalero closed 4 years ago

cesarsotovalero commented 4 years ago

Hello, I'm making this pull request because I noticed that guava was excluded from dependency littleproxy in commit https://github.com/vmi/selenese-runner-java/commit/9e6f39a71fc66f0310915265c2b7692897703960. Looking at the dependency tree at that time, I think this exclusion was made to fix a potential conflict between guava versions 19.0 (used by selenium-api) and version 14.0 (used by littleproxy). In that case, version 14.0 was put in the classpath because it was closer to the root of the project. However, now selenium-java declared guava version 25.0-jre as a direct dependency, avoiding the conflict. Therefore the exclusion can be removed without any problem.

On the other hand, I also noticed that findbugs and selenium-opera-driver are not used and can be excluded safely from selenium-java.

vmi commented 4 years ago

Thank you for PR!