vmichalak / sonos-controller

Java API for controlling SONOS players
MIT License
43 stars 9 forks source link

SonosDevice::getZoneName is actually SonosDevice::getRoomName #24

Open mguntli opened 6 years ago

mguntli commented 6 years ago

As far as I understood the Sonos system, every speaker can have a name. Example with three speakers:

A) GetZoneGroupAttributes / CurrentZoneGroupName If all three speakers are joined together, the "CurrentZoneGroupName" returns "Living Room + 1".

B) http://sonosip:1400/status/zp

C) http://sonosip:1400/device_description.xml

Proposal: Rename "getZoneName" to "getRoomName", get the room name from device_description.xml

vmichalak commented 6 years ago

I'm ok with the idea to rename getZoneName to getRoomName but it seems strange to loose the position information no ? Perhaps a third method ?

In the configuration :

where Living Room and Bedroom are joined.

It's better no ?

vmichalak commented 6 years ago

This night i gonna implement it on another branch to test it.

mguntli commented 6 years ago

Correct, I think your solution is the best one (Zone / Room / Device). The Sonos App basically just lists the Rooms to choose from, which is I think the easiest to understand for the users.

vmichalak commented 6 years ago

Also, I gonna rename setZoneName() to setRoomName().

vmichalak commented 6 years ago

@mguntli can you check on feature/24-get-room-name branch ?