search

vmichalak / sonos-controller

Java API for controlling SONOS players
MIT License
43 stars 9 forks source link

Add getFavoriteRadioShows() method #38

Closed Fabian95qw closed 5 years ago

Fabian95qw commented 5 years ago

Implemented getter for a three types of Favorites: Radio Stations, Radio Shows, Sonos-Favorites. Not yet able to play them tough...

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-6.06%) to 75.202% when pulling 2d10e42011420a2d18f9f4d59b2adcf4e11c24c5 on Fabian95qw:dev into 21c912f33d87dc67c0938da29bc1fc0302b8ea54 on vmichalak:dev.

vmichalak commented 5 years ago

Hi Fabian95qw, Thanks for your work on sonos-controller. Please, can you add Unit test ?

Fabian95qw commented 5 years ago

Hi Fabian95qw, Thanks for your work on sonos-controller. Please, can you add Unit test ?

Hello vmichalak

I've never done that before, but i'll look into it, and add them to the Pull-Request

Fabian95qw commented 5 years ago

I created the Test for the Favorite.class. I looked at how the Test for the Trackmetedata was designed. Is that enough? Or do i need to create the SonosDeviceTests as well?