search

vmichnowicz / vwm_polls

Free ExpressionEngine Poll Module and Fieldtype
Apache License 2.0
16 stars 8 forks source link

EE3 #38

Closed PSkaggs closed 7 years ago

PSkaggs commented 7 years ago

I started converting this to work in EE3. This current version works on EE3, however, I think when updating from the EE2 version the user needs to remove the previous version then load the new version. Also, the Google Charts should be updated to the new API.

I don't know how many people, if any, are asking you for this, but here is something to use.

vmichnowicz commented 7 years ago

Wow, it works with EE3!? I have not tried out EE3 so I cannot confirm or test these changes.

VWM Polls was only designed for EE2 so perhaps this code should go in an ee3 branch as it seems you have in your fork. It looks like you cannot create a pull request to a new branch so I'll have to add a new branch for this pull request to go to.

PSkaggs commented 7 years ago

It does work. I have it working on a client's installation, and I've installed it on a new installation and both seem to work well. It probably needs some more testing, but I've sort of moved on to other things. I'm happy to help with anything that comes up though.

I'm not sure how in demand this will be because it appears that not many people are switching to EE3. I don't see much in the forums about it. However, there may be someone that will find it useful.

vmichnowicz commented 7 years ago

Awesome! I created an ee3 branch for this code. If you change the target of the merge to this branch and resolve the merge conflicts I'll merge the pull request.

Then I'll add a note on the README that if anyone is looking for an EE3 version to checkout that branch.