vmihalko / t2_polkit

Other
0 stars 0 forks source link

[question,feature request] subprojects directory appears to be missing from the 0.119 tarball #148

Open vmihalko opened 3 years ago

vmihalko commented 3 years ago

In GitLab by @Binary-Eater on Jun 13, 2021, 21:34

The release tarball, https://www.freedesktop.org/software/polkit/releases/polkit-0.119.tar.gz, appears to be missing the subprojects directory containing the mocklibc.wrap files. Not sure if this is intentional in design, but I think it would be useful to provide. This would enable users downloading the release tarballs to be able to run tests using meson without needing to make extra downloads to support testing.

I noticed that the packagecache is checked into the repository as well. I was wondering if that is intentional? Also looking at the mocklibc.wrap file, it appears to me that it checks out the upstream version of mocklibc instead of the vendored copy in the repository. I am wondering if that is ok since there appear to be changes made that the upstream project doesn't have included.

vmihalko commented 3 years ago

In GitLab by @jtojnar on Jun 17, 2021, 10:00

Relevant meson docs: https://mesonbuild.com/Creating-releases.html#include-subprojects-in-your-release

vmihalko commented 1 year ago

In GitLab by @mattst88 on Mar 16, 2023, 18:38

mentioned in issue accountsservice/accountsservice#111