vmihalko / t2_polkit

Other
0 stars 0 forks source link

Arbitrary test timeout is too short for polkitbackendjsauthority #165

Closed vmihalko closed 1 year ago

vmihalko commented 3 years ago

In GitLab by @smcv on Oct 28, 2021, 13:42

From a Debian x86_64 autobuilder log:

1/5 polkitunixusertest            OK              0.01s
2/5 polkitunixgrouptest           OK              0.01s
3/5 polkitunixnetgrouptest        OK              0.01s
4/5 polkitidentitytest            OK              0.01s
5/5 test-polkitbackendjsauthority OK             26.41s

This is uncomfortably close to Meson's 30s default timeout: even on x86, it would only take a small amount of extra load (or a slightly slower CPU?) to make this test time out. On slower CPU architectures like mips and riscv64, it does time out.

It would probably be a good idea to raise this timeout, perhaps to more like 2 minutes.

vmihalko commented 3 years ago

In GitLab by @smcv on Oct 28, 2021, 13:44

For now, I'm going to extend the timeout in the Debian packaging, so we can get a better idea of how long this actually takes in practice on slow/embedded CPUs.

vmihalko commented 2 years ago

In GitLab by @tomf on Jan 18, 2022, 15:08

I observe timeouts at 30s of test-polkitbackendjsauthority on an ARM Quad core Cortex-A53.

vmihalko commented 2 years ago

In GitLab by @smcv on Jan 26, 2022, 19:21

From the Debian autobuilders, which run on relatively "big" (server-class) machines for the various architectures:

So I think maybe 60-120 seconds would be safer.

vmihalko commented 2 years ago

In GitLab by @smcv on Jan 26, 2022, 19:29

mentioned in commit smcv/polkit@4afd490b7587f91799bf948094861e210dca4802

vmihalko commented 2 years ago

In GitLab by @jrybar on Feb 21, 2022, 09:31

mentioned in commit smcv/polkit@f812483db4d48d23acf4605ff19be4787c6f8711