search

vmihalko / t2_polkit

Other
0 stars 0 forks source link

Port JavaScript authority to mozjs-78 - [closed] #267

Closed vmihalko closed 1 year ago

vmihalko commented 4 years ago

In GitLab by @valentindavid on Jul 7, 2020, 09:52

Merges valentindavid/mozjs78 -> master

vmihalko commented 4 years ago

In GitLab by @valentindavid on Jul 7, 2020, 09:54

added 1 commit

Compare with previous version

vmihalko commented 4 years ago

In GitLab by @valentindavid on Jul 7, 2020, 09:56

Not sure Fedora has mozjs78 yet though.

vmihalko commented 4 years ago

In GitLab by @fzatlouk on Jul 10, 2020, 16:21

I am planning to work on packaging mozjs78 into Fedora next week once I get back from PTO. It shouldn't take long.

@jrybar can you take a look at this one pretty please? I assume GNOME in F33 is gonna use mozjs78, so it'd be amazing to have polkit in sync.

Thanks @valentindavid for working on this.

vmihalko commented 4 years ago

In GitLab by @jrybar on Jul 10, 2020, 17:39

I will work on polkit from Jul 20 as I'm out of town now.
I will make a release with mozjs68 then for other distros to incorporate it as needed, then I will make another release with mozjs78 if all is good ;)

Sorry for the delay, lot of work on other projects. Please stay tuned.

vmihalko commented 4 years ago

In GitLab by @kalev on Jul 20, 2020, 12:55

@ptomato, here's another polkit mozjs MR if you want to help review this :)

vmihalko commented 4 years ago

In GitLab by @ptomato on Jul 20, 2020, 21:23

I assume GNOME in F33 is gonna use mozjs78

It's not certain yet.

vmihalko commented 4 years ago

In GitLab by @ptomato on Jul 20, 2020, 21:26

Commented on src/polkitbackend/polkitbackendjsauthority.cpp line 487

This change is currently done in the GJS branch for mozjs78, but I don't know yet for sure whether these options are equivalent.

You could probably get away with removing these options (IonMonkey, Baseline JIT, AsmJS) altogether, since polkit runs only very short scripts, they probably never get hot enough to JIT anyway.

vmihalko commented 4 years ago

In GitLab by @valentindavid on Jul 24, 2020, 10:23

Commented on src/polkitbackend/polkitbackendjsauthority.cpp line 487

changed this line in version 3 of the diff

vmihalko commented 4 years ago

In GitLab by @valentindavid on Jul 24, 2020, 10:23

added 1 commit

Compare with previous version

vmihalko commented 4 years ago

In GitLab by @valentindavid on Jul 24, 2020, 10:23

Commented on src/polkitbackend/polkitbackendjsauthority.cpp line 487

I removed it.

vmihalko commented 4 years ago

In GitLab by @xry111 on Jul 31, 2020, 05:59

Remember to change AX_CXX_COMPILE_STDCXX in configure.ac to use C++ 17. mozjs-78 requires that.

vmihalko commented 4 years ago

In GitLab by @jrybar on Jul 31, 2020, 17:55

Well, it's not a big deal for me to make a post-release patch to update dependency on mozjs78 in Fedora once it's there.

vmihalko commented 4 years ago

In GitLab by @jrybar on Aug 25, 2020, 18:39

Tested on Fedora 32, 33 and Rawhide.
I guess there's no reason to postpone this MR.
It had to be rebased though, so merged as !64. Closing this MR.
Thank you, @valentindavid and all of you!

vmihalko commented 4 years ago

In GitLab by @jrybar on Aug 25, 2020, 18:39

closed