vmihalko / t2_polkit

Other
0 stars 0 forks source link

Add out param GI annotation to polkit_implicit_authorization_from_string - [merged] #287

Closed vmihalko closed 1 year ago

vmihalko commented 3 years ago

In GitLab by @valpackett on Jun 1, 2021, 15:31

Merges master -> master

This helps binding generators like the Rust gir crate recognize the out parameter and generate correct handling code.

vmihalko commented 3 years ago

In GitLab by @jrybar on Jun 11, 2021, 15:26

added 4 commits

Compare with previous version

vmihalko commented 3 years ago

In GitLab by @jrybar on Jul 19, 2021, 16:29

added 7 commits

Compare with previous version

vmihalko commented 2 years ago

In GitLab by @jrybar on Mar 29, 2022, 11:44

I need to ask: why this one particular function? Why not others? After skimming through other headers, this seems like a single case of documenting a prototype.

vmihalko commented 2 years ago

In GitLab by @valpackett on Mar 31, 2022, 01:45

As I said in the description: because it has an out parameter. For lots of GI consumers, such as Rust, this matters a lot. g-ir-scanner parses these doc comments for annotations like out that influence the generated GI files. I don't think there's a more compact way of providing them than a full doc comment?

vmihalko commented 1 year ago

In GitLab by @jrybar on Apr 25, 2023, 09:56

added 75 commits

Compare with previous version

vmihalko commented 1 year ago

In GitLab by @jrybar on Apr 25, 2023, 09:56

enabled an automatic merge when the pipeline for ba7ca81d8f8fd3604bfc2c2a1fdb45c61b0dfd67 succeeds