Improve meson_post_install script - [merged]

[vmihalko]

In GitLab by @smcv on Jun 3, 2021, 19:37

Merges meson-post-install -> master

• meson_post_install: Use geteuid instead of getpass

• meson_post_install: Don't fail if the polkitd user doesn't exist yet

  If the package is being built in a minimal container or chroot, the user might not exist at build-time. Distributions like Debian often create system users on a just-in-time basis when the package that needs them is installed, but a minimal container or chroot probably doesn't have polkit.

  Resolves: #139

• meson_post_install: If installation steps are skipped, say what is needed

• meson_post_install: Don't install pkexec group-writable

  If group 0 isn't root-equivalent, then letting it write to pkexec would be a privilege escalation vector. Make it 0o4755 instead, which is consistent with the old Autotools build system.

• meson_post_install: Don't make programs setuid if we are not root

  If we're installing unprivileged into a ${DESTDIR}, there's no point in the programs being setuid to a non-root uid.

• CI: Don't pre-create the polkitd user

  This makes sure we do the right thing when building in a minimal container or chroot where that user doesn't exist.

[vmihalko]

In GitLab by @smcv on Jun 3, 2021, 20:15

added 1 commit

• f1ab488b - meson_post_install: Respect DESTDIR for absolute paths

Compare with previous version

[vmihalko]

In GitLab by @smcv on Jun 3, 2021, 20:52

added 2 commits

• f0177cd7 - meson_post_install: Respect DESTDIR for absolute paths
• 08a0a949 - CI: Exercise a DESTDIR installation

Compare with previous version

[vmihalko]

In GitLab by @smcv on Jun 3, 2021, 22:42

marked this merge request as ready

[vmihalko]

In GitLab by @smcv on Jun 11, 2021, 16:27

added 12 commits

• 08a0a949...025f9a6b - 4 commits from branch polkit:master
• 2c4060ae - meson_post_install: Use geteuid instead of getpass
• e0a0a4f2 - meson_post_install: Don't fail if the polkitd user doesn't exist yet
• 4f11ca72 - meson_post_install: If installation steps are skipped, say what is needed
• f462a1bf - meson_post_install: Don't install pkexec group-writable
• eff1b919 - meson_post_install: Don't make programs setuid if we are not root
• 6bd3b637 - CI: Don't pre-create the polkitd user
• 1d192317 - meson_post_install: Respect DESTDIR for absolute paths
• 18ccc08b - CI: Exercise a DESTDIR installation

Compare with previous version

[vmihalko]

In GitLab by @Aduskett on Jul 4, 2021, 21:19

All: Tested-by: Adam Duskett aduskett@gmail.com

Thank you so much! This fixes building 0.119 in Yocto and Buildroot!