vmihalko / t2_polkit

Other
0 stars 0 forks source link

pkexec: Don't chdir(~) - [merged] #323

Closed vmihalko closed 1 year ago

vmihalko commented 2 years ago

In GitLab by @AdrianVovk on Mar 31, 2022, 08:54

Merges polkit-ux -> master

Because pkexec changes directories, it is difficult to use pkexec like you would use sudo or doas.

See: https://gitlab.freedesktop.org/polkit/polkit/-/issues/98

vmihalko commented 2 years ago

In GitLab by @AdrianVovk on Mar 31, 2022, 08:54

added 5 commits

Compare with previous version

vmihalko commented 2 years ago

In GitLab by @AdrianVovk on Apr 6, 2022, 23:49

added 3 commits

Compare with previous version

vmihalko commented 2 years ago

In GitLab by @jrybar on Apr 7, 2022, 16:51

Hello, definitely not changing the default behavior after X years of this way,
but having it under parameter shouldn't be a problem.

vmihalko commented 2 years ago

In GitLab by @jrybar on Apr 7, 2022, 16:52

Also, please, if you're going to add a parameter for it, don't do --amend, create a separate commit for it. This will ease the review up. Thank you.

vmihalko commented 2 years ago

In GitLab by @AdrianVovk on Apr 12, 2022, 18:08

added 4 commits

Compare with previous version

vmihalko commented 2 years ago

In GitLab by @AdrianVovk on Apr 12, 2022, 18:10

@jrybar alright I've implemented a --keep-cwd option and documented it. Let me know if anything else is necessary :smile:

vmihalko commented 2 years ago

In GitLab by @AdrianVovk on Apr 26, 2022, 23:07

added 4 commits

Compare with previous version

vmihalko commented 2 years ago

In GitLab by @AdrianVovk on May 1, 2022, 04:50

added 4 commits

Compare with previous version

vmihalko commented 2 years ago

In GitLab by @AdrianVovk on May 1, 2022, 04:51

Bump. Is there anything else I need to do to get this in? Thanks

vmihalko commented 2 years ago

In GitLab by @AdrianVovk on May 4, 2022, 24:23

Thank you!