vmihalko / t2_polkit

Other
0 stars 0 forks source link

backend: Dedup some code for temporary auth subjects (MR #18 rebased) - [merged] #328

Closed vmihalko closed 1 year ago

vmihalko commented 2 years ago

Merges walters-polkit-dedup-subj-conversion -> master

This is MR #18 rebased.

Original description from MR #18:

See https://bugs.freedesktop.org/show_bug.cgi?id=23867 which turned up fromgit annotate` here.

I was reading this code and noticed it was duplicated.

vmihalko commented 2 years ago

requested review from @jrybar

vmihalko commented 2 years ago

In GitLab by @jrybar on May 13, 2022, 15:27

Commented on src/polkitbackend/polkitbackendinteractiveauthority.c line 3071

@vmihalko, can this be in a {} block too, please? It looks consistent with the rest of the code and prevents oversights when editing the code after some veeery long time. Thanks!

vmihalko commented 2 years ago

changed this line in version 2 of the diff

vmihalko commented 2 years ago

added 1 commit

Compare with previous version

vmihalko commented 2 years ago

marked this merge request as draft from vmihalko/polkit@d7cde817768c738acac51d7236ae4e28146e6e92

vmihalko commented 2 years ago

added 1 commit

Compare with previous version

vmihalko commented 2 years ago

Sure!

vmihalko commented 2 years ago

resolved all threads

vmihalko commented 2 years ago

marked this merge request as ready